stream: pause/resume on destroyed streams should be noop by ronag · Pull Request #62557 · nodejs/node

ronag · 2026-04-02T06:09:02Z

No description provided.

nodejs-github-bot · 2026-04-02T06:09:07Z

Review requested:

@nodejs/streams

PR-URL: nodejs#62557

mcollina

lgtm

nodejs-github-bot · 2026-04-02T07:22:00Z

CI: https://ci.nodejs.org/job/node-test-pull-request/72407/

codecov · 2026-04-02T07:31:12Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.71%. Comparing base (e0d2e1c) to head (e6edbb5).
⚠️ Report is 24 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #62557      +/-   ##
==========================================
- Coverage   89.72%   89.71%   -0.02%     
==========================================
  Files         695      695              
  Lines      214142   214160      +18     
  Branches    41001    41008       +7     
==========================================
- Hits       192137   192125      -12     
  Misses      14078    14078              
- Partials     7927     7957      +30

Files with missing lines	Coverage Δ
lib/internal/streams/readable.js	`97.17% <100.00%> (+<0.01%)`	⬆️

... and 28 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

nodejs-github-bot · 2026-04-02T19:59:06Z

CI: https://ci.nodejs.org/job/node-test-pull-request/72437/

nodejs-github-bot · 2026-04-03T09:59:03Z

CI: https://ci.nodejs.org/job/node-test-pull-request/72447/

nodejs-github-bot · 2026-04-04T17:57:44Z

CI: https://ci.nodejs.org/job/node-test-pull-request/72468/

nodejs-github-bot · 2026-04-04T18:38:29Z

Commit Queue failed

- Loading data for nodejs/node/pull/62557
✔  Done loading data for nodejs/node/pull/62557
----------------------------------- PR info ------------------------------------
Title      stream: pause/resume on destroyed streams should be noop (#62557)
Author     Robert Nagy <ronagy@icloud.com> (@ronag)
Branch     ronag:pause-resume-destroyed -> nodejs:main
Labels     stream, author ready, needs-ci
Commits    1
 - stream: pause/resume on destroyed streams should be noop
Committers 1
 - Robert Nagy <ronagy@icloud.com>
PR-URL: https://github.com/nodejs/node/pull/62557
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/62557
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Thu, 02 Apr 2026 06:09:02 GMT
   ✔  Approvals: 2
   ✔  - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/62557#pullrequestreview-4048608318
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/62557#pullrequestreview-4052829186
   ✘  GitHub CI failed with status: FAILURE
   ℹ  Last Full PR CI on 2026-04-04T17:57:44Z: https://ci.nodejs.org/job/node-test-pull-request/72468/
- Querying data for job/node-test-pull-request/72468/
✔  Build data downloaded
- Querying failures of job/node-test-commit/86749/
✔  Data downloaded
   ✘  1 failure(s) on the last Jenkins CI run
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/23985093997

nodejs-github-bot · 2026-04-04T19:33:46Z

CI: https://ci.nodejs.org/job/node-test-pull-request/72471/

nodejs-github-bot · 2026-04-05T08:20:13Z

Commit Queue failed

- Loading data for nodejs/node/pull/62557 ✔ Done loading data for nodejs/node/pull/62557 ----------------------------------- PR info ------------------------------------ Title stream: pause/resume on destroyed streams should be noop (#62557) Author Robert Nagy <ronagy@icloud.com> (@ronag) Branch ronag:pause-resume-destroyed -> nodejs:main Labels stream, author ready, needs-ci Commits 1 - stream: pause/resume on destroyed streams should be noop Committers 1 - Robert Nagy <ronagy@icloud.com> PR-URL: https://github.com/nodejs/node/pull/62557 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/62557 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> -------------------------------------------------------------------------------- ℹ This PR was created on Thu, 02 Apr 2026 06:09:02 GMT ✔ Approvals: 3 ✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/62557#pullrequestreview-4048608318 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/62557#pullrequestreview-4052829186 ✔ - Trivikram Kamat (@trivikr): https://github.com/nodejs/node/pull/62557#pullrequestreview-4059173985 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2026-04-04T19:33:46Z: https://ci.nodejs.org/job/node-test-pull-request/72471/ - Querying data for job/node-test-pull-request/72471/ ✔ Build data downloaded ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 62557 From https://github.com/nodejs/node * branch refs/pull/62557/merge -> FETCH_HEAD ✔ Fetched commits as 4b3d82c71d2a..e6edbb55add0 -------------------------------------------------------------------------------- [main 96cd212b5e] stream: pause/resume on destroyed streams should be noop Author: Robert Nagy <ronagy@icloud.com> Date: Thu Apr 2 08:08:25 2026 +0200 2 files changed, 16 insertions(+) ✔ Patches applied -------------------------------------------------------------------------------- ⚠ Found PR-URL: https://github.com/nodejs/node/pull/62557, skipping.. --------------------------------- New Message ---------------------------------- stream: pause/resume on destroyed streams should be noop

Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

[main 2c124770a9] stream: pause/resume on destroyed streams should be noop
Author: Robert Nagy <ronagy@icloud.com>
Date: Thu Apr 2 08:08:25 2026 +0200
2 files changed, 16 insertions(+)
✖ 2c124770a91736c6d469f7316a9982b934f1fa58
✔ 0:0 no Co-authored-by metadata co-authored-by-is-trailer
✔ 0:0 skipping fixes-url fixes-url
✔ 0:0 blank line after title line-after-title
✔ 0:0 line-lengths are valid line-length
✔ 0:0 metadata is at end of message metadata-end
✖ 0:0 Commit must have a PR-URL. pr-url
✔ 0:0 reviewers are valid reviewers
✔ 0:0 valid subsystems subsystem
✔ 0:0 Title is formatted correctly. title-format
⚠ 0:50 Title should be <= 50 columns. title-length

ℹ Please fix the commit message and try again.
Please manually ammend the commit message, by running
git commit --amend
Once commit message is fixed, finish the landing command running
git node land --continue

https://github.com/nodejs/node/actions/runs/23997586155

gurgunday

lgtm

ronag requested a review from mcollina April 2, 2026 06:09

stream: pause/resume on destroyed streams should be noop

e6edbb5

PR-URL: nodejs#62557

nodejs-github-bot added needs-ci PRs that need a full CI run. stream Issues and PRs related to the stream subsystem. labels Apr 2, 2026

ronag force-pushed the pause-resume-destroyed branch from 142dc31 to e6edbb5 Compare April 2, 2026 06:09

ronag requested a review from jasnell April 2, 2026 06:11

mcollina approved these changes Apr 2, 2026

View reviewed changes

ronag added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Apr 2, 2026

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 2, 2026

lpinca approved these changes Apr 2, 2026

View reviewed changes

lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 2, 2026

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 2, 2026

ronag added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 4, 2026

nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Apr 4, 2026

trivikr approved these changes Apr 5, 2026

View reviewed changes

ronag added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Apr 5, 2026

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 5, 2026

nodejs-github-bot added the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Apr 5, 2026

gurgunday approved these changes Apr 5, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

stream: pause/resume on destroyed streams should be noop#62557

stream: pause/resume on destroyed streams should be noop#62557
ronag wants to merge 1 commit intonodejs:mainfrom
ronag:pause-resume-destroyed

ronag commented Apr 2, 2026

Uh oh!

nodejs-github-bot commented Apr 2, 2026

Uh oh!

mcollina left a comment

Uh oh!

nodejs-github-bot commented Apr 2, 2026

Uh oh!

codecov bot commented Apr 2, 2026 •

edited

Loading

Uh oh!

nodejs-github-bot commented Apr 2, 2026

Uh oh!

nodejs-github-bot commented Apr 3, 2026

Uh oh!

nodejs-github-bot commented Apr 4, 2026

Uh oh!

nodejs-github-bot commented Apr 4, 2026

Uh oh!

nodejs-github-bot commented Apr 4, 2026

Uh oh!

nodejs-github-bot commented Apr 5, 2026

Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

Uh oh!

gurgunday left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Uh oh!

Conversation

ronag commented Apr 2, 2026

Uh oh!

nodejs-github-bot commented Apr 2, 2026

Uh oh!

mcollina left a comment

Choose a reason for hiding this comment

Uh oh!

nodejs-github-bot commented Apr 2, 2026

Uh oh!

codecov bot commented Apr 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

nodejs-github-bot commented Apr 2, 2026

Uh oh!

nodejs-github-bot commented Apr 3, 2026

Uh oh!

nodejs-github-bot commented Apr 4, 2026

Uh oh!

nodejs-github-bot commented Apr 4, 2026

Uh oh!

nodejs-github-bot commented Apr 4, 2026

Uh oh!

nodejs-github-bot commented Apr 5, 2026

Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

Uh oh!

gurgunday left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

codecov bot commented Apr 2, 2026 •

edited

Loading

Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>